Feature #338

[PATCH] Inspector.xib, Player.xib small changes

Added by Johan Lundström almost 2 years ago. Updated over 1 year ago.

Status:New Start Date:05/06/2010
Priority:Normal Due date:
Assigned to:Adrian Stutz % Done:

0%
Category:gui_controls
Target version:rev14

Description

I had a couple of small annoyances I wanted to fix with MPE. I thought I'd give back the changes I made and I hope they'll get merged into trunk. The changes:

  • Inspector.xib: make title field non-editable.
  • Inspector.xib: Playback statistics section's labels were aligned with other labels.
  • Player.xib: Changed skip right and skip left buttons to match full screen controls.
  • Inspector.xib: Truncate tail of location and filename in "File Attributes".

As you see they're small changes. I have a Github repo at http://github.com/johanlunds/mplayerosx (please, check the commits-page for more details). The changes were made to rev14-test2 (SVN trunk at r414).

Apply attached patch:

  1. download patch and pngs on this page
  2. "cd mplayerosx && patch -p1 < changes.patch"
  3. put pngs into mplayerosx/Resources/Graphics

I was very careful not to change anything else in the IB/Xcode-files. I also made sure to keep all margins intact when doing UI changes. Here's a screenshot with annotations: http://skitch.com/johanlunds/dnfm7/screen-shot-2010-05-06-at-02.51.40

Next I'd like to redo the playlist window to make it fit in better and make it easier to use. I wanted to consult you first if you already got plans for that.

skipRightTemplate.png (584 Bytes) Johan Lundström, 05/06/2010 07:24 am

skipLeftTemplate.png (592 Bytes) Johan Lundström, 05/06/2010 07:24 am

52515c9931d0fb6_d9d547b7d0051f69d.patch (43.2 kB) Johan Lundström, 05/06/2010 07:24 am

247aded5fd609c2dbb20c_985489939785458fb0e.patch (39 kB) Johan Lundström, 05/06/2010 04:25 pm

History

#1
Updated by Johan Lundström almost 2 years ago

One more change:

  • Inspector.xib: make the numbers and percentages in "Playback Statistics"
    left-aligned and give them number formatters (includes removing the unnecessary
    labels to the right).

Apply patch:

Like before, but dependent on the earlier patch. "cd mplayerosx && patch -p1 < changes.patch".

Picture: http://skitch.com/johanlunds/dn8ik/screen-shot-2010-05-06-at-16.18.49-1 (also shows "Truncate tail of location and filename in 'File Attributes'." which were in the last patch, but not in it's screenshot).

#2
Updated by Lorenzo F over 1 year ago

Love it, I was really annoyed by the editable field! I really hope these'll be integrated into the main trunk!
This project is getting polished a lot lately (interface-wise) and I feel the whole package is really starting to come together!

P.S. Awesome wallpaper! You into macro photography?

#3
Updated by Johan Lundström over 1 year ago

Two more, small changes:

  • MPlayerInterface.m: The sub scaling feature in the Inspector didn't work as intended. The new value would be set to x^2, not x. Changed the slider to always scale relatively to "Sub Scale" set in Preferences instead (commit)
  • TimestampTextField.m: When total time is unknown/zero or invalid (e.g. after launch) display it as "00:00:00" instead of "xx:xx:xx". This is currently the case for current and remaining, and I felt it was a pretty natural way to do things. (commit)

I can attach the patch if you want, or you could just do:

1. git clone git://github.com/johanlunds/mplayerosx.git
3. git log and git diff to find commits and generate diffs for them
4. Applying the diff is just patch -p1 < changes.patch

Lorenzo: Not really, just nice wallpapers. :) I always find mine on Interfacelift.com which have amazingly beautiful photographs.

Also available in: Atom PDF